softened version check and set default version to 13.0#503
Open
th3hamm0r wants to merge 1 commit intomobolic:masterfrom
Open
softened version check and set default version to 13.0#503th3hamm0r wants to merge 1 commit intomobolic:masterfrom
th3hamm0r wants to merge 1 commit intomobolic:masterfrom
Conversation
This change removes the check against VALID_API_VERSIONS, which always required changes to the library, when a new Graph API version has been released.
gautammd
approved these changes
Feb 13, 2022
|
Could this be merged and published on pip? |
|
Can this be released? or should everyone just fork this package when we want to work with GraphAPI after February? |
|
@martey could you please review and possibly merge this pr and publish it? Without enabling versions up to v17 this library becomes very very limited for future use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the check against VALID_API_VERSIONS, which always required changes to the library (eg #496, #502), when a new Graph API version has been released. Instead only the pattern check is executed.
I've also changed the default API version to the latest Graph API version v13.0.